Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calamares: 3.3.9 -> 3.3.10. calamares-nixos-extensions: 3.3.18 -> 3.3.19 #352694

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

vlinkz
Copy link
Member

@vlinkz vlinkz commented Oct 31, 2024

  • Update calamares version
  • Update calamares-nixos-extensions version
  • Fix GNOME wayland keyboard patch for latest version

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@vlinkz vlinkz requested a review from emilazy October 31, 2024 19:12
@ofborg ofborg bot requested a review from manveru November 1, 2024 01:37
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 1, 2024
@ElvishJerricco
Copy link
Contributor

@vlinkz this looks good to me, and I'll test it shortly. Do you happen to know if this will address this issue? I see some things in the calamares changelog that makes think it might.

@vlinkz
Copy link
Member Author

vlinkz commented Nov 3, 2024

Supposedly it should, but in practice I didn't see it fixed. GNOME works fine for me, but Plasma not. Apparently if kwin is started with locale1, it should work fine by default according to calamares' keyboard.conf, which we do have set in sddm. So I'm guessing this is more a NixOS specific issue, but I'll need to dig deeper to see.

@ElvishJerricco ElvishJerricco merged commit cdf3866 into NixOS:master Nov 6, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants